hopefully you've made a few errors on your diagram (good effort by the way).
the vent from the top of the cylinder should exit over the cold water storage tank.
there should be a vent over the feed & expansion tank from the primary side.
you show two pipes coming from the f/e tank ?